From 4a37afc09c4f068315a3b98fe8178953144d17d9 Mon Sep 17 00:00:00 2001 From: Trask Stalnaker Date: Wed, 6 Nov 2024 15:29:53 -0800 Subject: [PATCH] Remove sampling relevant from metrics --- docs/database/cosmosdb.md | 5 ----- docs/database/database-metrics.md | 10 ---------- model/database/common.yaml | 2 -- 3 files changed, 17 deletions(-) diff --git a/docs/database/cosmosdb.md b/docs/database/cosmosdb.md index 3b75b969ae..3e668a0e20 100644 --- a/docs/database/cosmosdb.md +++ b/docs/database/cosmosdb.md @@ -381,11 +381,6 @@ Instrumentations SHOULD document how `error.type` is populated. **[9]:** When observed from the client side, and when communicating through an intermediary, `server.address` SHOULD represent the server address behind any intermediaries, for example proxies, if it's available. -The following attributes can be important for making sampling decisions -and SHOULD be provided **at span creation time** (if provided at all): - -* [`db.namespace`](/docs/attributes-registry/db.md) - `db.cosmosdb.consistency_level` has the following list of well-known values. If one of them applies, then the respective value MUST be used; otherwise, a custom value MAY be used. | Value | Description | Stability | diff --git a/docs/database/database-metrics.md b/docs/database/database-metrics.md index a82e7ccbd8..145dff3c29 100644 --- a/docs/database/database-metrics.md +++ b/docs/database/database-metrics.md @@ -169,11 +169,6 @@ For batch operations, if the individual operations are known to have the same qu Even though parameterized query text can potentially have sensitive data, by using a parameterized query the user is giving a strong signal that any sensitive data will be passed as parameter values, and the benefit to observability of capturing the static part of the query text by default outweighs the risk. This attribute has stability level RELEASE CANDIDATE. -The following attributes can be important for making sampling decisions -and SHOULD be provided **at span creation time** (if provided at all): - -* [`db.collection.name`](/docs/attributes-registry/db.md) - `db.system` has the following list of well-known values. If one of them applies, then the respective value MUST be used; otherwise, a custom value MAY be used. | Value | Description | Stability | @@ -359,11 +354,6 @@ For batch operations, if the individual operations are known to have the same qu Even though parameterized query text can potentially have sensitive data, by using a parameterized query the user is giving a strong signal that any sensitive data will be passed as parameter values, and the benefit to observability of capturing the static part of the query text by default outweighs the risk. This attribute has stability level RELEASE CANDIDATE. -The following attributes can be important for making sampling decisions -and SHOULD be provided **at span creation time** (if provided at all): - -* [`db.collection.name`](/docs/attributes-registry/db.md) - `db.system` has the following list of well-known values. If one of them applies, then the respective value MUST be used; otherwise, a custom value MAY be used. | Value | Description | Stability | diff --git a/model/database/common.yaml b/model/database/common.yaml index 5d776a2f28..27d0817220 100644 --- a/model/database/common.yaml +++ b/model/database/common.yaml @@ -50,7 +50,6 @@ groups: requirement_level: conditionally_required: If available - ref: db.namespace - sampling_relevant: true requirement_level: conditionally_required: If available. note: "" # overriding the base note @@ -73,7 +72,6 @@ groups: requirement_level: recommended: if readily available or if instrumentation supports query summarization. - ref: db.collection.name - sampling_relevant: true requirement_level: conditionally_required: > If readily available and if a database call is performed on a single collection.