Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log or raise when creating invalid instruments in API #2143

Closed
Tracked by #2140
aabmass opened this issue Sep 23, 2021 · 3 comments
Closed
Tracked by #2140

Log or raise when creating invalid instruments in API #2143

aabmass opened this issue Sep 23, 2021 · 3 comments
Labels
1.10.0rc1 release candidate 1 for metrics GA api Affects the API package. metrics

Comments

@aabmass
Copy link
Member

aabmass commented Sep 23, 2021

  • For a similar issue in the metrics SIG, someone brought up the idea of a strict MeterProvider (or option to pass) that you can use to strictly raise exceptions for these in unit tests.
  • In the SDK, you should also return a no-op instrument if you only log a warning.
@aabmass aabmass added the api Affects the API package. label Dec 14, 2021
@ocelotl
Copy link
Contributor

ocelotl commented Dec 15, 2021

This could be uniformly handled by an error handling mechanism, see #2244

@lzchen lzchen added the 1.10.0rc1 release candidate 1 for metrics GA label Jan 11, 2022
@lzchen lzchen self-assigned this Jan 20, 2022
@lzchen lzchen removed their assignment Mar 7, 2022
@aabmass
Copy link
Member Author

aabmass commented Apr 15, 2022

I think this is covered now. Closing and we can open a new issue if we determine there's a problem

@aabmass aabmass closed this as completed Apr 15, 2022
@lzchen
Copy link
Contributor

lzchen commented Apr 15, 2022

@aabmass
Is this fixed already? I don't see a linked PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.10.0rc1 release candidate 1 for metrics GA api Affects the API package. metrics
Projects
None yet
Development

No branches or pull requests

3 participants