Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An invalid name should return a working no-op Meter implementation #1200

Closed
codeboten opened this issue Oct 5, 2020 · 3 comments · Fixed by #2428
Closed

An invalid name should return a working no-op Meter implementation #1200

codeboten opened this issue Oct 5, 2020 · 3 comments · Fixed by #2428
Assignees
@lzchen
Labels
1.10.0rc1 release candidate 1 for metrics GA api Affects the API package. bug Something isn't working feature-request metrics triaged

Comments

@codeboten
Copy link
Contributor

As per spec, a default meter should be returned if an invalid instrumentation name is specified in get_meter:
https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/metrics/api.md#obtaining-a-meter
@codeboten codeboten added bug Something isn't working api Affects the API package. metrics labels Oct 5, 2020
@codeboten codeboten self-assigned this Oct 5, 2020
@codeboten codeboten added release:required-for-ga To be resolved before GA release 1.10.0rc1 release candidate 1 for metrics GA labels Nov 26, 2020
@codeboten codeboten added release:metrics-ga and removed release:required-for-ga To be resolved before GA release labels Mar 9, 2021
@codeboten codeboten removed their assignment Mar 9, 2021
@github-actions
Copy link

github-actions bot commented Apr 9, 2021

This issue was marked stale due to lack of activity. It will be closed in 30 days.

@srikanthccv
Copy link
Member

This is still needed and it should also log a message reporting that the specified value is invalid. New API spec https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/new_api.md#get-a-meter

@ocelotl
Copy link
Contributor

ocelotl commented Dec 15, 2021

This could be uniformly handled by an error handling mechanism, see #2244

@lzchen lzchen self-assigned this Jan 20, 2022
@lzchen lzchen mentioned this issue Jan 31, 2022
Merged
@codeboten codeboten changed the title An invalid name should return a working default Meter implementation An invalid name should return a working no-op Meter implementation Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzchen lzchen

Labels
1.10.0rc1 release candidate 1 for metrics GA api Affects the API package. bug Something isn't working feature-request metrics triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return noopmeter on invalid name getmeter lzchen/opentelemetry-python
4 participants
@codeboten @ocelotl @lzchen @srikanthccv