diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d7fc509c3a..8ab75ce1c6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -269,6 +269,9 @@ Below is a checklist of things to be mindful of when implementing a new instrume - ex. - Appropriate error handling - ex. +- Isolate sync and async test + - For synchronous tests, the typical test case class is inherited from `opentelemetry.test.test_base.TestBase`. However, if you want to write asynchronous tests, the test case class should inherit also from `IsolatedAsyncioTestCase`. Adding asynchronous tests to a common test class can lead to tests passing without actually running, which can be misleading. + - ex. ## Expectations from contributors