Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis attributes not aligned with latest semantic conventions #1386

Open
luke6Lh43 opened this issue Sep 24, 2024 · 2 comments
Open

Redis attributes not aligned with latest semantic conventions #1386

luke6Lh43 opened this issue Sep 24, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@luke6Lh43
Copy link

luke6Lh43 commented Sep 24, 2024

Describe your environment

PHP 8.3.11
Composer 2.7.9
Slim 4.0

"open-telemetry/sdk": "^1.0"
"open-telemetry/opentelemetry-auto-slim": "^1.0"
"open-telemetry/opentelemetry-auto-psr18": "^1.0"
"mismatch/opentelemetry-auto-redis": "^0.3.0"
"open-telemetry/exporter-otlp": "^1.0"

Steps to reproduce
https://github.com/luke6Lh43/otel-redis-testing/blob/main/Readme.md#php

What is the expected behavior?
See below

What is the actual behavior?
See below

Additional context

I have recently been working on a project that required Redis instrumentation for two different languages. During this process, I noticed some discrepancies in the attributes being collected. To investigate further, I conducted testing to check the attributes collected for Redis instrumentation across six of the most popular languages. I have documented my testing in this GitHub repository:

[Link to GitHub Repo]

Findings for PHP:

What We Capture Today ==> How It Should Look in Latest Semantic Conventions

server.address: 127.0.0.1 ==> server.address: 127.0.0.1
network.transport: tcp ==> Not sure if it's needed
server.port: 6379 ==> server.port: 6379
db.system: redis ==> db.system: redis
db.statement: ==> db.statement: GET simple_text_message
(Not captured) ==> db.redis.database_index: 0

@luke6Lh43 luke6Lh43 added the bug Something isn't working label Sep 24, 2024
@brettmc
Copy link
Collaborator

brettmc commented Sep 25, 2024

Hello,
we're aware of the problem, and it exists in various forms across most of our instrumentations. The reason for this is that we're trying to conform to the moratorium(s) in this part of the spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/telemetry-stability.md#schema-file-driven-telemetry-producers
So, if there's a way to get these attributes into the current semconv version, I think we can do that, otherwise we're waiting for that moratorium to be lifted...

@bobstrecansky
Copy link
Collaborator

bobstrecansky commented Oct 9, 2024

The package "mismatch/opentelemetry-auto-redis": "^0.3.0" isn't maintained by us, so we probably need to get the creator to contribute to the opentelemetry-php-instrumentation repo and make some tweaks for it to be usable. Going to follow up with them in their repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants