Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Dockerfile): set USER_GID alongside USER_UID #738

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(Dockerfile): set USER_GID alongside USER_UID #738

wants to merge 1 commit into from
+8 −4

Conversation

rogercoll
Copy link
Contributor

Fixes #662

@rogercoll rogercoll requested review from a team as code owners November 18, 2024 08:59
iblancasa
iblancasa reviewed Nov 18, 2024
View reviewed changes
Copy link

@iblancasa iblancasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should create a changelog for this because I'm not sure if this change can cause unexpected issues in some environments.

@rogercoll
Copy link
Contributor Author

I think we should create a changelog for this because I'm not sure if this change can cause unexpected issues in some environments.

Is there any related documentation guidelines? I could not find any changelog file in the repo

@swiatekm
Copy link

I think we use the autogenerated Github release notes in this repo. So no separate changelog necessary.

@mowies
Copy link
Member

mowies commented Nov 18, 2024

would it not be better to add an actual collector changelog entry as a backport in the other repo(s)? This seems important enough to warrant that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@iblancasa iblancasa iblancasa approved these changes

@ChrsMark ChrsMark Awaiting requested review from ChrsMark ChrsMark is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

container user 10001 is group root.
5 participants
@rogercoll @swiatekm @mowies @iblancasa @TylerHelmuth