Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scraperinttest] Print error logs even if FailOnErrorLogs not specified #36392

Open
hughesjj opened this issue Nov 15, 2024 · 0 comments
Open

Comments

@hughesjj
Copy link
Contributor

Component(s)

No response

Is your feature request related to a problem? Please describe.

Right now, we can only get error logs if we specify scraperinttest.FailOnErrorLogs. This means that, if the test fails, we'll get something like "Condition never satisfied" instead of the root cause

Describe the solution you'd like

Let's take the first half of that conditional and put an else in that just does Logf

Describe alternatives you've considered

Perhaps it's better to always specify FailOnErrorLogs, if so we should document that

Additional context

No response

@hughesjj hughesjj added enhancement New feature or request needs triage New item requiring triage labels Nov 15, 2024
@mx-psi mx-psi added Contribfest priority:p2 Medium internal/scrapertest and removed enhancement New feature or request internal/scrapertest needs triage New item requiring triage labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants