Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flaky test] [cmd/opampsupervisor] TestSupervisorRemoteConfigApplyStatus flaky #36278

Closed
songy23 opened this issue Nov 8, 2024 · 4 comments · Fixed by #36282
Closed

[Flaky test] [cmd/opampsupervisor] TestSupervisorRemoteConfigApplyStatus flaky #36278

songy23 opened this issue Nov 8, 2024 · 4 comments · Fixed by #36282
Labels
ci-cd CI, CD, testing, build issues cmd/opampsupervisor flaky test a test is flaky os:windows

Comments

@songy23
Copy link
Member

songy23 commented Nov 8, 2024

Component(s)

cmd/opampsupervisor

Describe the issue you're reporting

https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11746011659/job/32725597882

=== RUN   TestSupervisorRemoteConfigApplyStatus
    e2e_test.go:163: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/cmd/opampsupervisor/e2e_test.go:163
        	            				D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/cmd/opampsupervisor/e2e_test.go:1475
        	Error:      	Received unexpected error:
        	            	yaml: line 15: did not find expected hexdecimal number
        	Test:       	TestSupervisorRemoteConfigApplyStatus
    e2e_test.go:132: Shutting down
--- FAIL: TestSupervisorRemoteConfigApplyStatus (5.01s)
@songy23 songy23 added ci-cd CI, CD, testing, build issues flaky test a test is flaky os:windows needs triage New item requiring triage cmd/opampsupervisor labels Nov 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Pinging code owners for cmd/opampsupervisor: @evan-bradley @atoulme @tigrannajaryan. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@pjanotti
Copy link
Contributor

pjanotti commented Nov 8, 2024

Another hit at https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11746397279/job/32726652184?pr=36252#step:7:949

@pjanotti
Copy link
Contributor

pjanotti commented Nov 8, 2024

The issue is that the temporary path used in the test is passed as text to an yaml file so the Windows dir separator ends up as a escape char on the yaml.

@pjanotti pjanotti mentioned this issue Nov 8, 2024
Merged
@pjanotti pjanotti removed the needs triage New item requiring triage label Nov 8, 2024
pull bot pushed a commit to abaguas/opentelemetry-collector-contrib that referenced this issue Nov 9, 2024
@pjanotti @pull
[test] Fix opampsupervisor test on Windows (open-telemetry#36282)
e53ffa8 
Fix open-telemetry#36278

The issue is that the temporary path used in the test is passed as text
to an yaml file so the Windows dir separator ends up as a escape char on
the yaml.
@github-actions github-actions bot mentioned this issue Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci-cd CI, CD, testing, build issues cmd/opampsupervisor flaky test a test is flaky os:windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[test] Fix opampsupervisor test on Windows pjanotti/opentelemetry-service-contrib
2 participants
@pjanotti @songy23