Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] Automated release prep fails on missing module #36246

Open
djaglowski opened this issue Nov 6, 2024 · 1 comment
Open

[release] Automated release prep fails on missing module #36246

djaglowski opened this issue Nov 6, 2024 · 1 comment
Labels
release-retro Issues discussed in a release retrospective

Comments

@djaglowski
Copy link
Member

Component(s)

No response

Describe the issue you're reporting

Observed here: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11710819322/job/32617968986#step:5:134

/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/builder --skip-compilation --config cmd/otelcontribcol/builder-config.yaml --output-path cmd/otelcontribcol
Flag --output-path has been deprecated, use config distribution::output_path
2024-11-06T19:50:41.343Z	INFO	internal/command.go:97	OpenTelemetry Collector Builder	{"version": "v0.113.0"}
2024-11-06T19:50:41.343Z	INFO	internal/command.go:102	Using config file	{"path": "cmd/otelcontribcol/builder-config.yaml"}
2024-11-06T19:50:41.346Z	INFO	builder/config.go:159	Using go	{"go-executable": "/opt/hostedtoolcache/go/1.22.8/x64/bin/go"}
2024-11-06T19:50:41.358Z	INFO	builder/main.go:100	Sources created	{"path": "cmd/otelcontribcol"}
Error: failed to update go.mod: go subcommand failed with args '[mod tidy -compat=1.22]': exit status 1, error message: go: downloading github.com/open-telemetry/opentelemetry-collector-contrib/receiver/ntpreceiver v0.[113](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11710819322/job/32617968986#step:5:114).0
go: downloading go.opentelemetry.io/collector/confmap/provider/envprovider v1.19.0
go: downloading go.opentelemetry.io/collector/confmap/provider/fileprovider v1.19.0
go: downloading go.opentelemetry.io/collector/confmap/provider/httpprovider v1.19.0
go: downloading go.opentelemetry.io/collector/confmap/provider/httpsprovider v1.19.0
go: downloading go.opentelemetry.io/collector/confmap/provider/yamlprovider v1.19.0
go: downloading go.opentelemetry.io/collector/connector/forwardconnector v0.113.0
go: downloading go.opentelemetry.io/collector/exporter/debugexporter v0.113.0
go: downloading go.opentelemetry.io/collector/exporter/nopexporter v0.113.0
go: downloading go.opentelemetry.io/collector/exporter/otlpexporter v0.113.0
go: downloading go.opentelemetry.io/collector/exporter/otlphttpexporter v0.113.0
go: downloading go.opentelemetry.io/collector/extension/zpagesextension v0.113.0
go: downloading go.opentelemetry.io/collector/otelcol v0.113.0
go: downloading go.opentelemetry.io/collector/processor/batchprocessor v0.113.0
go: downloading go.opentelemetry.io/collector/processor/memorylimiterprocessor v0.113.0
go: downloading go.opentelemetry.io/collector/receiver/nopreceiver v0.113.0
go: downloading go.opentelemetry.io/collector/receiver/otlpreceiver v0.113.0
go: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/[email protected]: reading github.com/open-telemetry/opentelemetry-collector-contrib/receiver/ntpreceiver/go.mod at revision receiver/ntpreceiver/v0.113.0: unknown revision receiver/ntpreceiver/v0.113.0
@djaglowski djaglowski added release:blocker The issue must be resolved before cutting the next release release-retro Issues discussed in a release retrospective labels Nov 6, 2024
djaglowski added a commit that referenced this issue Nov 6, 2024
Possibly resolves the immediate issue faced in
#36246,
but not the root cause. Either way, I'm unclear how to test this outside
of the release process itself.
@djaglowski djaglowski removed the release:blocker The issue must be resolved before cutting the next release label Nov 6, 2024
@djaglowski
Copy link
Member Author

The immediate problem appears to have been resolved by #36247.

However, this issue should remain open until we have a solution which prevents this from occurring in the first place. I think that likely needs to take the form of a CI check that validates that every local module in the builder manifest has a corresponding replace directive.

michael-burt pushed a commit to michael-burt/opentelemetry-collector-contrib that referenced this issue Nov 7, 2024
…ry#36247)

Possibly resolves the immediate issue faced in
open-telemetry#36246,
but not the root cause. Either way, I'm unclear how to test this outside
of the release process itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-retro Issues discussed in a release retrospective
Projects
None yet
Development

No branches or pull requests

1 participant