[processor/span] Add 'keep_original_name' #36120
Closed
+89
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @fatsheep9146 and @atoulme, would you mind taking a look at this whenever you can? :) |
atoulme
approved these changes
Nov 13, 2024
|
Thanks for the chat during KubeCon OTel Contribfest @lopes-felipe! Happy to merge this pull request as soon as the conflicts are resolved. |
jpkrohling
pushed a commit
that referenced
this pull request
Nov 16, 2024
This is another version of #36120 with fixed conflicts. Thanks @lopes-felipe for creating it! #### Description Some tracing libraries add some attributes into the span name ([ex for the `db.system`](https://github.com/DataDog/dd-trace-java/blob/a420d2c66ade70af0ebc8c58ee2d4784bb0de38a/dd-java-agent/agent-otel/otel-shim/src/main/java/datadog/opentelemetry/shim/trace/OtelConventions.java#L168)), which can be further used to extract it as span attributes with this very processor. However, when that is done, the span name is replaced by a placeholder containing the attribute name. This PR adds the possibility of keeping the original span name unchanged with a `keep_original_name` config property, but keeping the existing behavior (renaming the span) as the default option. --------- Co-authored-by: Felipe Lopes <[email protected]>
|
Merged via #36397 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some tracing libraries add some attributes into the span name (ex for the
db.system), which can be further used to extract it as span attributes with this very processor. However, when that is done, the span name is replaced by a placeholder containing the attribute name.This PR adds the possibility of keeping the original span name unchanged with a
keep_original_nameconfig property, but keeping the existing behavior (renaming the span) as the default option.