Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No validation when the osp-system-structure contains more than one output connected to the same input #89

Open
cesarcarc opened this issue Nov 1, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@cesarcarc
Copy link

cesarcarc commented Nov 1, 2021

Setup:

  • Configuration with two models (Damper and Mass, from tutorial example).
  • Two outputs from the model Damper (df_0 and df_1) connected to the input from the model mass (in_f_u), as in the file attached (see next message).

Action 1:

  • run the osp-validator on the configuration
    java -jar osp-cli.jar osp-system-structure -file "OspSystemStructure.xml"

Result 1:
No error!

Action 2:

  • run the cosim-cli
    .\cosim.exe run "OspSystemStructure.xml"

Result 2:
Error message is shown:
error: Invalid system structure: Cannot establish connection between variables Damper1:df_1 and Mass1:in_f_u: Target variable is already connected to Damper1:df_0

I believe the osp-validator should be able to detect this type of error (multiple outputs connected to the same input), as this configuration would not run.

@cesarcarc cesarcarc added the bug Something isn't working label Nov 1, 2021
@cesarcarc
Copy link
Author

Config.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant