Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding Buddy's Pizza #44

Merged
merged 4 commits into from
Oct 20, 2023
Merged

feat: adding Buddy's Pizza #44

merged 4 commits into from
Oct 20, 2023

Conversation

chrisdemars
Copy link
Contributor

@chrisdemars chrisdemars commented Oct 19, 2023 •
edited by CBID2
Loading

Description

This PR adds Buddy's Rendezvou to the regional pizza spots.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Related to #35

Mobile & Desktop Screenshots/Recordings

n/a

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

n/a

[optional] What gif best describes this PR or how it makes you feel?

@CBID2 CBID2 linked an issue Oct 19, 2023 that may be closed by this pull request
Add Regional pizza style to repo (Please Keep Open) #35
Open
CBID2
CBID2 reviewed Oct 19, 2023
View reviewed changes
regional-pizza.md Outdated Show resolved Hide resolved
CBID2
CBID2 reviewed Oct 19, 2023
View reviewed changes
regional-pizza.md Outdated Show resolved Hide resolved
CBID2
CBID2 reviewed Oct 19, 2023
View reviewed changes
regional-pizza.md Outdated Show resolved Hide resolved
CBID2
CBID2 suggested changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chrisdemars! :) Welcome to OpenSauced! :) Your entry is off to a great start. It just needs a few tweaks.

@chrisdemars
Copy link
Contributor Author

@CBID2 all should be fixed

CBID2
CBID2 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@CBID2 CBID2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now moving on to more pressing measures...

  1. Detroit Pizza sounds awesome! :)
  2. Let's merge this PR!! :)
  3. A little tip: Always fill out every section of the pull request form. It helps maintainers and other contributors understand how to review your contribution. For more tips, check out the blog post, Writing Your First Pull Request: Tips, Best Practices, and AI-Powered Tools for Success. If you want to find other projects to contribute to, join our Discord! 😊 We'd love to work with you! 😊

@CBID2 CBID2 merged commit abc6234 into open-sauced:main Oct 20, 2023
@chrisdemars
Copy link
Contributor Author

@CBID2 I wanted to submit another PR for a different pizza place but I keep getting a permission denied in my terminal.

@CBID2
Copy link
Contributor

CBID2 commented Oct 20, 2023

@CBID2 I wanted to submit another PR for a different pizza place but I keep getting a permission denied in my terminal.

Hi @chrisdemars! 😊 I'm discussing it with the community team, but I think it's because we're trying to keep it one PR a minimum.

@chrisdemars
Copy link
Contributor Author

@CBID2 I wanted to submit another PR for a different pizza place but I keep getting a permission denied in my terminal.

Hi @chrisdemars! 😊 I'm discussing it with the community team, but I think it's because we're trying to keep it one PR a minimum.

Oh that is a bummer lol. I was going to get my 4 PR's for Hacktoberfest, all pizza related stuff I could contribute.

@CBID2
Copy link
Contributor

CBID2 commented Oct 20, 2023 •
edited
Loading

@CBID2 I wanted to submit another PR for a different pizza place but I keep getting a permission denied in my terminal.

Hi @chrisdemars! 😊 I'm discussing it with the community team, but I think it's because we're trying to keep it one PR a minimum.

Oh that is a bummer lol. I was going to get my 4 PR's for Hacktoberfest, all pizza related stuff I could contribute.

Aww it'll be ok @chrisdemars. I'll give you an update on what the team says. In the meantime, check out this section of our Hacktoberfest page to see what other projects you can contribute to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBID2 CBID2 CBID2 approved these changes

Assignees

@chrisdemars chrisdemars

Labels
💡 feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Regional pizza style to repo (Please Keep Open)
2 participants
@chrisdemars @CBID2