Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Blog post highlights make up random repos #1995

Closed
1 of 2 tasks
bdougie opened this issue Oct 24, 2023 · 8 comments · Fixed by #2007
Closed
1 of 2 tasks

Bug: Blog post highlights make up random repos #1995

bdougie opened this issue Oct 24, 2023 · 8 comments · Fixed by #2007
Assignees
Labels
Milestone

Comments

@bdougie
Copy link
Member

bdougie commented Oct 24, 2023

Describe the bug

Screen Shot 2023-10-24 at 3 54 11 PM

Steps to reproduce

The need for recognition is not a repo and every blog highlight should be linked to a repo.

The solution should enforce a repo being tagged on a blog highlight.

Browsers

Chrome

Additional context (Is this in dev or production?)

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@bdougie bdougie added 🐛 bug Something isn't working 👀 needs triage labels Oct 24, 2023
@bdougie bdougie added this to the Papercuts milestone Oct 24, 2023
@github-actions
Copy link
Contributor

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@bdougie
Copy link
Member Author

bdougie commented Oct 24, 2023

Screen Shot 2023-10-24 at 4 05 54 PM

The input has a place to tag a repo, not sure why it is not required at the moment.

@shamimbinnur
Copy link
Contributor

Although it's triage labeled, can I take it anyway? @bdougie

@bdougie
Copy link
Member Author

bdougie commented Oct 25, 2023

We still need to triage it. We are trying to build a contributor culture where folks share an idea for the approach before we assign.

We have had too many issues sit assigned with no response for months. With that said, can you look at the code make a suggestion for an approach?

If you are on the @open-sauced/triage team, you are able to remove the label.

@shamimbinnur
Copy link
Contributor

Why is this happening:

Currently, the repository is being tagged automatically based on the link given by the user.
The logic behind extracting the repo URL from the given link is not handled for the blog post.
That's the reason it is just splitting unwanted text from the blog link and treating it as a repository URL.

The logic here

The way it can be fixed:

  1. Implement logic to prevent automatic extraction of the repository URL when it's a blog post.
  2. Since no repository is currently tagged, display an alert message prompting the user to tag at least one repository.

@bdougie

@bdougie
Copy link
Member Author

bdougie commented Oct 25, 2023

Thanks for exploring this @shamimbinnur. Assigned

@open-sauced
Copy link
Contributor

open-sauced bot commented Oct 26, 2023

🎉 This issue has been resolved in version 1.73.0-beta.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced
Copy link
Contributor

open-sauced bot commented Oct 26, 2023

🎉 This issue has been resolved in version 1.73.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced open-sauced bot added the released label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants