Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Allow multiple thumbnail / assets paths #484

Open
1 task done
Briancbn opened this issue Feb 2, 2024 · 4 comments
Open
1 task done

[Feature request]: Allow multiple thumbnail / assets paths #484

Briancbn opened this issue Feb 2, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Briancbn
Copy link
Contributor

Briancbn commented Feb 2, 2024

Before proceeding, is there an existing issue or discussion for this?

Description

It seems that right now the thumbnails only allow 1 path. Allowing more paths should help with third-party or creating custom thumbnails that can be maintained in another repo, or for customer sensitive thumbnails.

I think this will be helpful especially I want to upload the demo I did here a long time ago with custom assets to be available instead of upload a lot of extra picture here, those assets are quite specific to the demo and might not be relevant to the use case that other people is using traffic editor for.

Implementation Considerations

I suggest something like

path1:path2

which is similar to a $PATH
or add in an add button to add in multiple lines of input to add in more path.

Alternatives

No response

Additional information

If this feature is something that the maintainer also thinks is useful. I would gladly help to make a Pull Request.

@Briancbn Briancbn added the enhancement New feature or request label Feb 2, 2024
@Yadunund
Copy link
Member

Yadunund commented Feb 3, 2024

I understand the need to support thumbnails for assets not only in rmf_traffic_editor_assets but one simple solution is to simlink your custom resource folder to the thumbnails folder that rmf_traffic_editor looksup.

or add in an add button to add in multiple lines of input to add in more path.

In this approach, we also need to support functionality to remove or edit one of multiple paths. At this point we would require a GUI like the Path Manger in Windows which allows users to CRUD multiple directories to $PATH.
If you're willing to contribute such a feature, we are happy to review the PR.

Ideally, all models are hosted on Fuel with thumbnails uploaded and we implement some mechanism to preview thumbnails of assets on Fuel. Something like this was already implemented by @luca-della-vedova in our rmf_site project.

@luca-della-vedova
Copy link
Member

Yap to add on to @Yadunund's comment I expect most upcoming feature development to happen on the rmf_site codebase, happy to review PRs here but probably won't have bandwidth to contribute major features anytime soon

@Briancbn
Copy link
Contributor Author

Briancbn commented Feb 7, 2024

Ideally, all models are hosted on Fuel with thumbnails uploaded and we implement some mechanism to preview thumbnails of assets on Fuel. Something like this was already implemented by @luca-della-vedova in our rmf_site project.

Good to hear the process on rmf_site! Is there a PR I can reference for this feature?

@Yadunund
Copy link
Member

Yadunund commented Feb 7, 2024

Ideally, all models are hosted on Fuel with thumbnails uploaded and we implement some mechanism to preview thumbnails of assets on Fuel. Something like this was already implemented by @luca-della-vedova in our rmf_site project.

Good to hear the process on rmf_site! Is there a PR I can reference for this feature?

Yes, the PR is linked in the original comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants