-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate option to use http request for model downloading #388
Comments
happy to work on this, but I would like to get a clear idea of the ideal result. From here:
I am guessing, would the model download process be something like
Some thoughts I had:
|
As per VC, this issue will only be related to refactoring and deprecating the option to download models using the Regarding, the discussion about exporting models, I have created a separate issue open-rmf/rmf_demos#89. As for reducing the number of workarounds we apply during model downloading, e.g. handling white space, changing names, etc, as you surmised, the ideal solution would be to improve the older models on Fuel, however I would expect plenty of users are using them as it is, and any major changes would break lots of simulation behaviors across the board. We should definitely revisit this once we get a better understanding on our simulation model needs some time soon. Thanks! |
yes thanks for clarifying! will dive in 🤽 |
Deprecation
Related to #386.
http
requests.ign-fuel-tools
moving forwards and support upstream development if we need any new features.The text was updated successfully, but these errors were encountered: