Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on open-rmf/rmf_utils#27
When building on macOS with the default Apple Compiler, several build errors are thrown as seen below (small sample)
It looks like the base classes such as Viewer or ItineraryViewer have virtual methods with
ParticipantID
as argument type whereas classes that implement these methods such asDatabase
orMirror
replaceParticipantId
withstd::size_t
. As a result the compiler think we're wrongly implementing the virtual methods.I'm actually surprised gcc or llvm-clang doesn't catch this same error?
I'm also assuming this change will break API/ABI so perhaps this should not be backported into
humble