-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Urdf import, export and workcell editor fixes #177
Conversation
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
There are a few rough edges here and there but this is "stable enough" that it should be pretty much OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this has been baking for quite a while and much of the implementation details are subject to change as we obtain better foundational tools in Bevy, so I'm only doing a cursory review to unblock this.
I only noticed a few things that seem off, and they're relatively minor, so I've opened issues #198 #199 #200.
New feature implementation
Implemented feature
Based on #155 by @audrow, extends urdf export to also export joint and inertial data, as well as add a urdf import feature to convert URDF into a
Workcell
object. Having both allows adding an integration test that performs a roundtrip conversion inrmf_site_format
and makes sure that the files match.I am also refining various parts of the workcell editor mode and fix issues I found along the way. Will change it to in review and add a more detailed description of the changes once it's ready.
Implementation description
Workcell
structure, including conversion back and forth fromurdf
.Workcell
format, including saving and loading to a site. No inspector is implemented yet though.NameInSite
components forNameInWorkcell
if the spawned object is a child of aWorkcell
. This will probably be removed in the future by having aNameInGroup
component that unifies the two.urdf
files through theOpen File
window.