Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: User-provided filename is not respected when exporting URDF #198

Open
mxgrey opened this issue Jan 23, 2024 · 2 comments
Open

[Bug]: User-provided filename is not respected when exporting URDF #198

mxgrey opened this issue Jan 23, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@mxgrey
Copy link
Collaborator

mxgrey commented Jan 23, 2024

Description of the bug

When exporting a workcell URDF, there is a file dialogue that lets you fill in a filename. Even if you provide a filename, the site editor will export a directory based on the original name of the workcell.

A better use experience would either:

  1. export using the new user-defined name (maybe the original workcell name can be filled in by default?)
  2. use AsyncFileDialog::new().pick_folder() instead of AsyncFileDialog::new().save_file()

Steps to reproduce the bug

Load a workcell and then export it as URDF

@mxgrey mxgrey added the bug Something isn't working label Jan 23, 2024
@luca-della-vedova
Copy link
Member

This is probably confusing UX but kinda intended.
The idea is that the name of the created folder is the name of the workcell, which is also the name of the robot in the exported URDF. The same name can also be used by other libraries that build on RMF site editor to (for example) create ROS 2 services or topics for the specific workcell.
Maybe a better solution could be to change the dialog to pick a folder?

@mxgrey
Copy link
Collaborator Author

mxgrey commented Jan 24, 2024

Maybe a better solution could be to change the dialog to pick a folder?

Yeah that would be fine and would be my recommendation (2).

But if we take that approach then we need to make sure there's a way for users to rename the workcell. I couldn't find a way to do that when I was trying out the workcell editor yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants