-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lane speed limit to graph parsing function #124
Conversation
Codecov Report
@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 21.40% 21.45% +0.05%
==========================================
Files 1260 840 -420
Lines 101676 67832 -33844
Branches 48378 32284 -16094
==========================================
- Hits 21760 14551 -7209
+ Misses 56505 37612 -18893
+ Partials 23411 15669 -7742
Flags with carried forward coverage won't be shown. Click here to find out more. |
Python bindings and their tests have been updated, this is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for also updating the Python bindings!
I'm not sure why there's a problem, but GitHub is complaining about unsigned commits. Maybe you can do a squash-merge with signing to fix it? |
Signed-off-by: Luca Della Vedova <[email protected]>
df39b5d
to
2c82e3b
Compare
Done! I squash merged the three commits and force pushed into a single signed commit |
Signed-off-by: Luca Della Vedova <[email protected]> Signed-off-by: Arjo Chakravarty <[email protected]>
New feature implementation
Implemented feature
Depends on open-rmf/rmf_traffic#44
This PR is to work towards open-rmf/rmf_traffic#43, it adds parsing the speed_limit from lane properties and assigning them to the rmf_traffic lanes.
Implementation description
The implementation is very simple but it cannot be really tested unless we add a unit test with a sample graph, in alternative we might need to address the remaining repos in the linked issue to get an end to end test in
rmf_demos
.