Hotfix/add missing source value #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MikhailBertrand <[email protected]>
Signed-off-by: MikhailBertrand <[email protected]>
MikhailBertrand
force-pushed
the
hotfix/add_missing_source_value
branch
from
b3df393
to
3e4b4a3
Compare
Yadunund
approved these changes
Aug 25, 2024
|
Thanks for submitting this fix! Will merge after CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
There was an issue in the code where the obstacle information was published within the
rmf_human_detector_oakdpackage. Theobstacle.idvalue was mistakenly inserted twice, leaving theobstacle.sourcefield empty.As a result, the
rmf_visualization_obstaclesnode ignored the published obstacle, preventing it from being displayed in rviz.https://github.com/open-rmf/rmf_visualization/blob/1130f2cc491736f7dc395abe032d364008c24900/rmf_visualization_obstacles/src/ObstacleVisualizer.cpp#L74-L80
It appears that the
detector_nameparameter was intended to be used as the source value in the obstacle information being published, so I made the necessary modifications.