Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swagger codegen typings #349

Open
koonpeng opened this issue May 24, 2021 · 0 comments
Open

Fix swagger codegen typings #349

koonpeng opened this issue May 24, 2021 · 0 comments

Comments

@koonpeng
Copy link
Collaborator

It seems the typescript-axios plugin does not generate correct typings, all the models have any type. The typescript-fetch plugin works as expected but is not immediately compatible with node without a "polyfill".

This get more important as we start to have more "custom" models. For example, the TaskProgress model is based off of rmf's TaskSummary message, with an additional field to indicate the current progress. These "custom" models are not reflected in rmf-models and must be imported from api-client. In the future, dashboard and react-component might not use rmf-models directly anymore, all model definitions will come from api-client.

We can either switch to typescript-fetch or attempt to fix typescript-axios upstream. Note that swagger codegen is a java project so that requires a different set of expertise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant