Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add style linting #100

Open
mxgrey opened this issue Aug 30, 2021 · 2 comments
Open

Add style linting #100

mxgrey opened this issue Aug 30, 2021 · 2 comments
Labels
quality Issues with code quality

Comments

@mxgrey
Copy link
Collaborator

mxgrey commented Aug 30, 2021

To comply with open-rmf/rmf#45 we should add style linting to this repository when time permits. I recommend waiting until after the current develop branch efforts are merged in.
@mxgrey mxgrey added the quality Issues with code quality label Aug 30, 2021
@aaronchongth
Copy link
Member

that's a great point, thanks! I'll remove the calls to rmf_uncrustify in the relevant packages in develop for now.

@mxgrey
Copy link
Collaborator Author

mxgrey commented Aug 30, 2021

Oh if it's already being added into develop, then it's totally fine to just keep it in. I only looked through main and saw that we aren't linting yet.

@aaronchongth aaronchongth mentioned this issue Sep 2, 2021
Closed
@aaronchongth aaronchongth mentioned this issue Oct 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
quality Issues with code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mxgrey @aaronchongth