Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent async channels from sending streams after the service finishes #29

Open
mxgrey opened this issue Oct 26, 2024 · 0 comments
Open
Assignees

Comments

@mxgrey
Copy link
Contributor

mxgrey commented Oct 26, 2024

Currently it is possible for a user to implement an async service that sends its async channel outside of the function scope so that the channel can outlive the function scope. Then the channel could continue to be used to transmit new stream signals after the service has terminated.

This violates bevy_impulse's contract that services cannot produce stream data after their final output has been delivered.

We should put a mechanism into the async channel that allows us to close it once we have received the final output for the service call that the channel was created for.

@mxgrey mxgrey self-assigned this Oct 26, 2024
@mxgrey mxgrey added this to PMC Board Oct 26, 2024
@github-project-automation github-project-automation bot moved this to Inbox in PMC Board Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant