Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NVRAM option awareness in op-test #492

Closed
oohal opened this issue May 6, 2019 · 1 comment · Fixed by #502
Closed

NVRAM option awareness in op-test #492

oohal opened this issue May 6, 2019 · 1 comment · Fixed by #502
Assignees
@sammj

Comments

@oohal
Copy link
Contributor

oohal commented May 6, 2019

NVRAM options are generally used to work around issues or enable debugging features without re-building a pnor. When enabled they can significantly change the behaviour of firmware so it probably not safe to allow arbitrary NVRAM overrides to be enabled on a system undergoing testing. As a part of the system setup op-test should at the very least check what nvram overrides are being used. Ideally it should clear any that are in use since stock firmware should never be using them.

Allowing a white-list of nvram options would be useful in some cases though. Some of our test systems use a bootargs override to disable malfunctioning hardware and NVRAM options can be useful for doing A/B testing of fixes.

For an example of how this can cause issues, see #491
@sammj
Copy link
Contributor

sammj commented May 6, 2019

Good idea!

@sammj sammj mentioned this issue May 7, 2019
Closed
sammj added a commit to sammj/op-test-framework that referenced this issue May 10, 2019
@sammj
Check Skiboot NVRAM options before testcase
2d55b0e 
Skiboot parses configuration options in NVRAM at boot time which affect
runtime behaviour, and several of these can be potentially dangerous or
detrimental. When possible check NVRAM for any Skiboot configuration
options and warn about them and the end of the test run.

Fixes open-power#492

Example:
2019-05-10 13:42:57,768:op-test.common.OpTestUtil:dump_nvram_opts:WARNING:
2 NVRAM debugging options set
These may adversely affect test results; verify these are appropriate if a failure occurs:
----------------------------------------------------------
bootargs=modprobe.blacklist=amdgpu
test-cfg=test-value
----------------------------------------------------------

Signed-off-by: Samuel Mendoza-Jonas <[email protected]>
@sammj sammj mentioned this issue May 10, 2019
Merged
@sammj sammj self-assigned this May 10, 2019
sammj added a commit that referenced this issue May 20, 2019
@sammj
Check Skiboot NVRAM options before testcase
e5295ee 
Skiboot parses configuration options in NVRAM at boot time which affect
runtime behaviour, and several of these can be potentially dangerous or
detrimental. When possible check NVRAM for any Skiboot configuration
options and warn about them and the end of the test run.

Fixes #492

Example:
2019-05-10 13:42:57,768:op-test.common.OpTestUtil:dump_nvram_opts:WARNING:
2 NVRAM debugging options set
These may adversely affect test results; verify these are appropriate if a failure occurs:
----------------------------------------------------------
bootargs=modprobe.blacklist=amdgpu
test-cfg=test-value
----------------------------------------------------------

Signed-off-by: Samuel Mendoza-Jonas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sammj sammj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check Skiboot NVRAM options before testcase sammj/op-test-framework
2 participants
@oohal @sammj