-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PRRTE build failure with GCC 14.2.1 on Fedora 40 #12881
Comments
Afraid that has nothing to do with me - it's a bug in the OMPI fork of PRRTE, not present in PRRTE itself. FWIW: we've seen some oddities in gcc 14.2, so it may not always be generating true issues. Not saying this one is in that category - just noting for future reference. |
Sorry, but I need a small clarification to avoid confusion in future interactions. If I do $grep url .git/modules/*/config | grep -v [email protected]:open-mpi
.git/modules/openpmix/config: url = [email protected]:openpmix/openpmix.git
.git/modules/prrte/config: url = [email protected]:openpmix/prrte it looks like both the openmpix and prrte submodules track the respective upstream repositories, and not forks within the open-mpi organization. In any case, thanks for the prompt fix. I'll wait until the submodule pointer gets updated. |
Hmmm...I'm pretty sure that isn't correct for OMPI main. I believe they pointed the PRRTE submodule at open-mpi/prrte, which is their fork. Unfortunately, the two aren't tracking very well. For example, that fix was committed upstream in early May! Note that the OMPI v5 branch does still point at upstream PRRTE, which may be what your little grep is hitting. |
OK, thanks for the clarification. My ompi@main clone is definitely still using the upstream prrte remote. I've been using git worktrees for checking out main/v5.0.x/v4.0x, I guess that worktrees do not play well with submodule URLs. PS: @bosilca @jsquyres If that is the case, that is, mixing git worktrees with git submodules is somewhat broken, then this issue may hit other easily, I think savvy git users use worktrees a lot. Perhaps the OMPI and PRRTE devs can negotiate a branch namespace on upstream PRRT (eg. have branches ompi/main and ompi/v5.0.x in the upstream PRRTE git repository) such that you can put there your commits to track as git submodules in the OMPI repository. That way, when switching OMPI branches (or checking out branches in other worktress), the remote URLs for submodules do not change. |
The bug you reported above only exists in the OMPI fork. Unless you haven't updated since May 7, you must be looking at the OMPI fork. |
OK, I definitely messed up, I never run @bosilca Is there any plain to cherry-pick openpmix/prrte#1976 into the open-mpi/prrte fork and update the submodule pointer? |
This is with ompi@main
cc @rhc54
The text was updated successfully, but these errors were encountered: