Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book next/previous button labels don't render HTML #94

Open
daveyboond opened this issue Oct 2, 2017 · 4 comments
Open

Book next/previous button labels don't render HTML #94

daveyboond opened this issue Oct 2, 2017 · 4 comments

Comments

@daveyboond
Copy link

Hi,

The text labels that accompany the buttons for "next chapter" and "previous chapter" in a Book resource display HTML tags as code, instead of rendering them. This is at odds with the rest of the Moodle interface, as shown in this screenshot.
image1

Steve

@gthomas2
Copy link
Contributor

gthomas2 commented Oct 2, 2017

It sounds like it's being escaped twice which normally happens when we transition renderer code to mustache templates. Thanks for reporting, I'll take a quick look.

@gthomas2
Copy link
Contributor

gthomas2 commented Oct 2, 2017

We've had a look at this and we can see why it's probably happening. Thanks for reporting.

@gthomas2
Copy link
Contributor

gthomas2 commented Oct 2, 2017

We've tried replicating this issue and have been unable to in 3.2 and 3.3. If we enter html into a book chapter title it is stripped out by Moodle. Can you provide steps to replicate please?

@daveyboond
Copy link
Author

daveyboond commented Oct 2, 2017

Hi, that's because we've turned off the setting in Site administration > Appearance > HTML settings that strips out HTML. So steps to replicate:

  1. Go to Site administration > Appearance > HTML settings and uncheck "Remove HTML tags from all activity names"
  2. Create a new Book. Create a first chapter called "<b>Bold</b>" and a 2nd chapter called "<i>Italics </i>"
  3. Save the Book and enter it. The button at bottom right should be labelled "Next: Italics" but in fact is labelled "Next: <i>Italics </i>"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants