Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate package within IDEAS.Examples.Tutorial for Modelica crash course examples #1389

Open
jelgerjansen opened this issue Nov 7, 2024 · 2 comments · May be fixed by #1404
Open
Assignees

Comments

@jelgerjansen
Copy link
Contributor

jelgerjansen commented Nov 7, 2024

The Modelica crash course examples used to be the only ones inside the IDEAS.Examples.Tutorial package, but the latest IBPSA merge (PR #1383) added a SimpleHouse package to the Tutorial package. The Crash course examples should therefore be collected in a seperate package as well (including some documentation).

@jelgerjansen jelgerjansen changed the title Create separate package within IDEAS.Fluid.Tutorial for Modelica crash course examples Create separate package within IDEAS.Examples.Tutorial for Modelica crash course examples Nov 7, 2024
@jelgerjansen
Copy link
Contributor Author

This can be tackled together with #1374

@LoneMeertens
Copy link

@jelgerjansen I created a separate package within IDEAS.Examples.Tutorial for the Modelica crash course examples, with a subpackage for each exercise to make the package more organized. As part of this, I moved the IDEAS.SimpleHouse example .mo file to Exercise 1.

Does this format look good for further development?

I believe the tests failed because the file paths have changed. Could there be any other issues causing the test failures?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants