Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Add
hostNetwork
anddnsPolicy
settings to enable compatibility with EKS clusters that have a custom CNI. Without these, the MutatingWebhook that adds the flagd sidecar to pods will not function.Related Issues
Notes
This relies on
.github/scripts/strip-kustomize-helm.sh
because boolean values have to be true/false without quotes, so to sethostNetwork
to true in the helm chart, we have to strip out the quotes that are used to allow kustomize to ignore helm chart directives.Follow-up Tasks
How to test
Test the operator with a test workload that uses the flagd sidecar on an EKS cluster with a custom CNI (Calico is most common).