Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add hostNetwork flag. #680

Conversation

cpitstick-latai
Copy link
Contributor

@cpitstick-latai cpitstick-latai commented Jun 17, 2024

This PR

Add hostNetwork and dnsPolicy settings to enable compatibility with EKS clusters that have a custom CNI. Without these, the MutatingWebhook that adds the flagd sidecar to pods will not function.

Related Issues

Notes

This relies on .github/scripts/strip-kustomize-helm.sh because boolean values have to be true/false without quotes, so to set hostNetwork to true in the helm chart, we have to strip out the quotes that are used to allow kustomize to ignore helm chart directives.

Follow-up Tasks

  • The ongoing issues related to the kustomize build process and the conflict with Helm continue to plague this type of system.

How to test

Test the operator with a test workload that uses the flagd sidecar on an EKS cluster with a custom CNI (Calico is most common).

@cpitstick-latai cpitstick-latai changed the title Add hostNetwork flag. feat: Add hostNetwork flag. Jun 17, 2024
@toddbaert
Copy link
Member

This seems right to me. The CNCF mandates you sign-off your commit though, so we implement some checks for that.

You can do git commit --amend --signoff and force push.

@cpitstick-latai cpitstick-latai force-pushed the cpitstick-latai/add-hostnetwork-flag branch from 58890dc to 60d068c Compare June 18, 2024 20:29
@cpitstick-latai
Copy link
Contributor Author

I did a sign off. However, it looks like the actions workflow experienced a transient failure!

@cpitstick-latai cpitstick-latai force-pushed the cpitstick-latai/add-hostnetwork-flag branch from 60d068c to e37324a Compare June 20, 2024 19:03
- Necessary for EKS clusters with a custom CNI.

Signed-off-by: Christopher Pitstick <[email protected]>
@cpitstick-latai cpitstick-latai force-pushed the cpitstick-latai/add-hostnetwork-flag branch from e37324a to 88e9f74 Compare June 20, 2024 19:17
@cpitstick-latai cpitstick-latai marked this pull request as ready for review June 20, 2024 19:24
@cpitstick-latai cpitstick-latai requested a review from a team as a code owner June 20, 2024 19:24
@cpitstick-latai
Copy link
Contributor Author

This should be ready to go now!

@toddbaert
Copy link
Member

Tested locally, looks good. I'll give 24h for others to review, but I think this is small enough to merge with 1 approval.

@toddbaert toddbaert merged commit 8e00a35 into open-feature:main Jun 28, 2024
15 checks passed
@github-actions github-actions bot mentioned this pull request Jun 28, 2024
@cpitstick-latai cpitstick-latai deleted the cpitstick-latai/add-hostnetwork-flag branch July 1, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EKS with custom CNI: operator needs hostNetwork enabled
3 participants