Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto-upgrade flagd-proxy with OFO upgrades #596

Merged
merged 9 commits into from
Jan 24, 2024

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Jan 15, 2024

Fixes: #583

Changes

  • support automatic upgrade of flagd-proxy Deployment and Service if they are not up-to-date with the required configuration by OFO and the current FeatureFlagSource configuration
  • tests
  • docs

@odubajDT odubajDT force-pushed the feat/583/flagd-proxy-update branch from 9ffa3e6 to 3c5d1ae Compare January 16, 2024 12:36
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (0affaa5) 88.00% compared to head (60217ef) 88.22%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
+ Coverage   88.00%   88.22%   +0.22%     
==========================================
  Files          10       10              
  Lines         934      960      +26     
==========================================
+ Hits          822      847      +25     
+ Misses         89       88       -1     
- Partials       23       25       +2     
Files Coverage Δ
common/flagdproxy/flagdproxy.go 88.37% <81.13%> (+1.38%) ⬆️
Flag Coverage Δ
unit-tests 88.22% <81.13%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT force-pushed the feat/583/flagd-proxy-update branch from 272fe75 to 62a94b6 Compare January 16, 2024 13:06
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT marked this pull request as ready for review January 17, 2024 07:32
@odubajDT odubajDT requested a review from a team as a code owner January 17, 2024 07:32
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left minor improvement suggestions, otherwise looks good

chart/open-feature-operator/README.md Outdated Show resolved Hide resolved
chart/open-feature-operator/README.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
docs/v1beta_migration.md Outdated Show resolved Hide resolved
Signed-off-by: odubajDT <[email protected]>
@odubajDT
Copy link
Contributor Author

Left minor improvement suggestions, otherwise looks good

Adapted, thank you!

chart/open-feature-operator/README.md Outdated Show resolved Hide resolved
chart/open-feature-operator/README.md Outdated Show resolved Hide resolved
common/flagdproxy/flagdproxy.go Show resolved Hide resolved
common/flagdproxy/flagdproxy.go Outdated Show resolved Hide resolved
common/flagdproxy/flagdproxy.go Outdated Show resolved Hide resolved
common/flagdproxy/flagdproxy.go Show resolved Hide resolved
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT force-pushed the feat/583/flagd-proxy-update branch from 2a0cda9 to 36467bc Compare January 22, 2024 07:11
@odubajDT odubajDT force-pushed the feat/583/flagd-proxy-update branch from 76125b9 to 31b5b49 Compare January 22, 2024 11:49
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only left a minor open suggestion for logging :) thanks @odubajDT for the contribution 🙌

common/flagdproxy/flagdproxy.go Outdated Show resolved Hide resolved
odubajDT and others added 2 commits January 23, 2024 08:02
Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT merged commit 3271f33 into open-feature:main Jan 24, 2024
16 of 17 checks passed
@github-actions github-actions bot mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-upgrade flagd-proxy version with OFO upgrades
5 participants