-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto-upgrade flagd-proxy with OFO upgrades #596
feat: auto-upgrade flagd-proxy with OFO upgrades #596
Conversation
9ffa3e6
to
3c5d1ae
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
==========================================
+ Coverage 88.00% 88.22% +0.22%
==========================================
Files 10 10
Lines 934 960 +26
==========================================
+ Hits 822 847 +25
+ Misses 89 88 -1
- Partials 23 25 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: odubajDT <[email protected]>
272fe75
to
62a94b6
Compare
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left minor improvement suggestions, otherwise looks good
Signed-off-by: odubajDT <[email protected]>
Adapted, thank you! |
Signed-off-by: odubajDT <[email protected]>
2a0cda9
to
36467bc
Compare
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
76125b9
to
31b5b49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I only left a minor open suggestion for logging :) thanks @odubajDT for the contribution 🙌
Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Fixes: #583
Changes