-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce FlagService CRD with reconciliation #417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyerus
force-pushed
the
issue-371/flagd-service
branch
from
March 24, 2023 14:30
a2eab28
to
3977908
Compare
Codecov Report
@@ Coverage Diff @@
## main #417 +/- ##
==========================================
- Coverage 78.12% 77.00% -1.13%
==========================================
Files 12 12
Lines 855 687 -168
==========================================
- Hits 668 529 -139
+ Misses 153 131 -22
+ Partials 34 27 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
skyerus
force-pushed
the
issue-371/flagd-service
branch
from
March 27, 2023 09:19
30376be
to
e6478be
Compare
Signed-off-by: Skye Gill <[email protected]>
Signed-off-by: Skye Gill <[email protected]>
Signed-off-by: Skye Gill <[email protected]>
Signed-off-by: Skye Gill <[email protected]>
Signed-off-by: Skye Gill <[email protected]>
Signed-off-by: Skye Gill <[email protected]>
Signed-off-by: Skye Gill <[email protected]>
Signed-off-by: Skye Gill <[email protected]>
Signed-off-by: Skye Gill <[email protected]>
Signed-off-by: Skye Gill <[email protected]>
skyerus
force-pushed
the
issue-371/flagd-service
branch
from
March 27, 2023 15:41
bf2f11d
to
7ac9376
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC
This is a WIP implementation of the FlagService OFEP.
This PR introduces a CRD named
FlagService
. The creation of aFlagService
CR (in OFO's namespace) triggers its reconciliation loop which does the following (in OFO's namespace):How to run the POC
The demo aims to exemplify a legitimate end-to-end deployment scenario by using Kubernetes Gateway API (KGA) to ingest traffic to a demo application & the created flagd Service/Deployment.
Prerequisites:
Note: To get this to work locally I had to add hostnames to my hosts file to route them to localhost. Without this the browser doesn't send the appropriate Host header to the Gateway, preventing it from being able to route the request.
Go to http://ofoclientapp.com:8080/ in your browser and click the Update color button to verify that the traffic is routed to flagd correctly.
Further Steps
Related Issues
#371
Notes
Follow-up Tasks
How to test