-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TESTING] remove testbed sync-server in favor of flagd v0.9.1+ #114
Comments
do we actually need the sync docker files? seems like https://github.com/open-feature/flagd-testbed/blob/main/flagd/Dockerfile is already doing what we want. i think we can delete the sync folder, or am i wrong here. side question, do we need to somehow deprecate some artefacts? or are they somewhere used? |
I think you're right @aepfli , we don't need another Dockerfile or image. I think we just need to expose a new port! |
i started removing the sync server
based on those two prs, we only need to remove the code, and we are actually ready for migration |
sync server is deprecated as it is part of flagd. Hence that we can remove all of the custom logic. closes: #114 Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
flagd itself now implements the sync.proto. This means the sync-server in this repo (only used for testing) can be replaced with flagd itself.
The text was updated successfully, but these errors were encountered: