Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TESTING] remove testbed sync-server in favor of flagd v0.9.1+ #114

Closed
2 tasks done
toddbaert opened this issue Mar 15, 2024 · 3 comments · Fixed by #153
Closed
2 tasks done

[TESTING] remove testbed sync-server in favor of flagd v0.9.1+ #114

toddbaert opened this issue Mar 15, 2024 · 3 comments · Fixed by #153
Labels
contribfest A good issue for Contribfest KubeCon EU '24 good first issue Good for newcomers help wanted Extra attention is needed

Comments

@toddbaert
Copy link
Member

toddbaert commented Mar 15, 2024

flagd itself now implements the sync.proto. This means the sync-server in this repo (only used for testing) can be replaced with flagd itself.

@toddbaert toddbaert added good first issue Good for newcomers help wanted Extra attention is needed contribfest A good issue for Contribfest KubeCon EU '24 labels Mar 15, 2024
@toddbaert toddbaert changed the title [TESTING] remove toy sync-server in favor of flagd v0.9.1+ [TESTING] remove testbed sync-server in favor of flagd v0.9.1+ Mar 16, 2024
@aepfli
Copy link
Member

aepfli commented Jun 7, 2024

do we actually need the sync docker files? seems like https://github.com/open-feature/flagd-testbed/blob/main/flagd/Dockerfile is already doing what we want. i think we can delete the sync folder, or am i wrong here. side question, do we need to somehow deprecate some artefacts? or are they somewhere used?

@toddbaert
Copy link
Member Author

I think you're right @aepfli , we don't need another Dockerfile or image. I think we just need to expose a new port!

@aepfli
Copy link
Member

aepfli commented Nov 22, 2024

i started removing the sync server

based on those two prs, we only need to remove the code, and we are actually ready for migration

aepfli added a commit that referenced this issue Nov 22, 2024
sync server is deprecated as it is part of flagd. Hence that we can remove all of the custom logic.

closes: #114

Signed-off-by: Simon Schrottner <[email protected]>
@aepfli aepfli linked a pull request Nov 22, 2024 that will close this issue
toddbaert pushed a commit that referenced this issue Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribfest A good issue for Contribfest KubeCon EU '24 good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants