Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhs2116 Stimulus Sequence Dialog - Plot pulses in red to highlight them #346

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bparks13
Copy link
Member

In addition to plotting the whole stimulus waveform, overlay the individual pulses in red to highlight them, making it easier to note the timings of individual pulses.

If pulses are too small (i.e., only has one step for the amplitude), it can be hard to visualize them still.

@bparks13 bparks13 added this to the 0.4.1 milestone Oct 22, 2024
@bparks13 bparks13 requested a review from jonnew October 22, 2024 16:14
- Modified the line widths so that the pulse overlay is more distinctive
@jonnew
Copy link
Member

jonnew commented Oct 25, 2024

This may or may not be related to this PR: the performance of plotting the waveforms seems to be poor enough that if a signficant number of stimuli are added, the GUI becomes nearly unresponsive. In the following video im trying to select channels, zoom, etc and there are multiple seconds between actions and refresh:

Untitled.video.-.Made.with.Clipchamp.mp4

@jonnew
Copy link
Member

jonnew commented Oct 25, 2024

Additionally, the section controls in the channel-visualizer (probe inface GUI) are a bit clunky. Selection seems to work ok, but removal is hard. Can I make a block selection and them e.g. click or shift-click individual selected electrodes to de-select them?

@bparks13
Copy link
Member Author

bparks13 commented Nov 4, 2024

Other potential ways to highlight where a pulse occurs that might be more performant

  • Instead of N extra objects from all the individual pulses, plot only 1 extra line that does not show the actual amplitude, but rather is at a fixed height whenever each pulse occurs
    • This could be an impulse (i.e., a raster plot at the start of each pulse), or a unit step function (i.e., rectangular pulse that is high for the duration of the pulse, and low the rest of the time)
  • Draw all lines that have a pulse anywhere with a different color than lines without a pulse
    • Currently the default line color is blue, and red for channels with invalid stimuli
    • We could add a different color (orange? green? I’m not sure) that we draw the waveform with when a pulse is present anywhere

@bparks13 bparks13 marked this pull request as draft November 4, 2024 15:53
@bparks13
Copy link
Member Author

bparks13 commented Nov 4, 2024

Converted to a draft, will come back to this if needed.

@bparks13 bparks13 removed this from the 0.4.1 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rhs2116 Stimulus Sequence Dialog - Plot pulses with a red overlay to highlight them
2 participants