-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify example workflows #84
Comments
This is a good idea. All the workflows with headstage should probably include the breakout. However, I don't think writing all the properties to file is practice. And, in fact its already done -- the .bonsai file contains all the values. |
The .bonsai file does save properties. However, for reproducibility, imo it would be even more robust if the user could save a file with those properties at the time that the workflow was started that is decoupled from the .bonsai file. Each data acquisition session reproduces the properties that were used during that session. Of course, this wouldn't work once we start taking into account acquisition properties which can be changed while the workflow is running. The first two bullet points in the original post: yes. That third bullet point feels like an item that would belong on a wish list. |
Part of resolving this issues is implementing the discussion in #97 |
Ah, i think i somehow misunderstood @ChucklesOnGitHub's original point. I think all she was saying is that all the workflows should have three common elements: If that's what she was indicating, then I agree |
Yes Jon, that's what I meant. The picture makes it super clear. Cris, I agree that it would be nice "if the user could save a file with those properties at the time that the workflow was started that is decoupled from the .bonsai file.", and that it can be part of the wishlist. In this issue I was only referring to the Timestamp node after the ConfigureHeadstage. |
The hs64 tutorial includes all of these, we have to revise np1e and np2e. bb example probably doesn't need these.
The text was updated successfully, but these errors were encountered: