Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build pipeline #10

Open
leif81 opened this issue Sep 2, 2021 · 9 comments
Open

Add build pipeline #10

leif81 opened this issue Sep 2, 2021 · 9 comments

Comments

@leif81
Copy link
Member

leif81 commented Sep 2, 2021

This project could use a build pipeline to ensure proposed changes don't break the build.

For future work we should integrate a unit tests into the build pipeline.

@mastertnt
Copy link

Hi,

I could if you are interrested, define the build pipeline with nuget package at the final step.

For the unit tests, i can also initiate something.

@leif81
Copy link
Member Author

leif81 commented Oct 5, 2021

@mastertnt yes that would be very much appreciated! Please submit a pull request when you're ready.

@mastertnt
Copy link

Ok, i have started.

First, i will submit the build pipeline then think about some tests.

@mastertnt
Copy link

Question : What is the goal of CSharpDis7 ? The latest version of DIS (2010) or a new way to implement ? Can i discard it ? in the build process ?

@leif81
Copy link
Member Author

leif81 commented Oct 10, 2021

Yes the Dis7 folder is for the 2010 version.

Yes it's ok to exclude it from the build for now.

@mastertnt
Copy link

The build process is ready, i am going to test it on a clean machine.

@mastertnt
Copy link

In the second pass, i will include DIS7.

@mastertnt
Copy link

Before the pull request, i have:

  • Port all projects to .NET 5.0 (now the library can be used on Linux and macOS)
  • Install a build system based on Nuke (https://nuke.build/)
  • Reorganize the sources in order to have a cleaner repo

@mastertnt
Copy link

mastertnt commented Oct 11, 2021

I submitted the PR. If you are interrested, i can become a maintainer of the C# version.

@leif81 leif81 linked a pull request Oct 13, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants