Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-K8S addon hooks #97

Open
ctron opened this issue May 24, 2022 · 1 comment
Open

Allow non-K8S addon hooks #97

ctron opened this issue May 24, 2022 · 1 comment
Assignees

Comments

@ctron
Copy link

ctron commented May 24, 2022

To me it looks like currently there are "pre deletion" hooks, which make use of the finalizer of a managed addon resource.

However, they only allow one to spawn a pod or a job. Assuming one wants to simply reach to an external API, that would mean spawning a job, with a simple HTTP call.

It would be great if the Agent interface would allow for a PreDelete function, which would handle the same, and report back with: ok, need-more-time, failed. Which is basically the same as a job would, just without spawning additional pods.

@qiujian16
Copy link
Member

/assign @zhiweiyin318

this was used to integrate with helm. but i think it makes sense to extend. @zhiweiyin318 thought?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants