Mysterious values referenced in helloword template

[MikeSpreitzer]

https://github.com/open-cluster-management-io/addon-framework/blob/main/examples/helloworld/manifests/templates/deployment.yaml references some values that are not explained in the documentation and, I suspect, may be outdated.

In that template I see the following mysterious value references.

• .Tolerations
• .NodeSelector
• .HTTPProxy
• .HTTPSProxy
• .NoProxy

Looking in https://github.com/open-cluster-management-io/addon-framework/blob/main/pkg/addonfactory/addondeploymentconfig.go I found ToAddOnNodePlacementValues and ToAddOnProxyConfigValues. These support the following references from a template.

• .tolerations
• .global.nodeSelector
• .global.proxyConfig.HTTP_PROXY
• .global.proxyConfig.HTTPS_PROXY
• .global.proxyConfig.NO_PROXY

They also support .global.proxyConfig.PROXY_CA_BUNDLE but the example template does not use anything like that.

I also found ToAddOnDeloymentConfigValues, which provides values named Tolerations and NodeSelector but nothing for proxy config. This function is not mentioned in https://open-cluster-management.io/developer-guides/addon/ .

[qiujian16]

cc @zhujian7