You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, we cannot deal with this when using categorical default rules, as they will render the categorical features unsupported rather than ignored.
While I am not aware of models that benefit from both unencoded categorical features and normalisation, we could still consider adding this, especially since users users are likely to apply unnecessary normalisation to, for example, tree-based models.
Proposal:
make add_categorical_default_rules accept not only bool but also an enum CategoricalRule with items UNSUPPORTED, IGNORED, NONE.
handle it appropriately
pass add_categorical_rules through to further subclasses, in particular TakeColumns.
Right now, we cannot deal with this when using categorical default rules, as they will render the categorical features unsupported rather than ignored.
While I am not aware of models that benefit from both unencoded categorical features and normalisation, we could still consider adding this, especially since users users are likely to apply unnecessary normalisation to, for example, tree-based models.
Proposal:
add_categorical_default_rules
accept not only bool but also an enumCategoricalRule
with itemsUNSUPPORTED
,IGNORED
,NONE
.add_categorical_rules
through to further subclasses, in particularTakeColumns
.@schroedk FYI
The text was updated successfully, but these errors were encountered: