Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Hidden Source Map Support (Feature Request) #40

Open
ndreckshage opened this issue Feb 2, 2016 · 14 comments
Open

Hidden Source Map Support (Feature Request) #40

ndreckshage opened this issue Feb 2, 2016 · 14 comments

Comments

@ndreckshage
Copy link

In addition to regular source map support, it would be nice to support hidden source maps, where the source map URI is not provided by the script. This would be helpful for production environments where we don't want to display source to anyone that opens devtools.

Maybe the ability to provide a key in opbeat application settings, and then opbeat could download the source map based on a standard pattern. Something like [path-to-file][somewhat-secret-key].js.map

Also, what IP does opbeat use to access the sourcemaps? Then we could limit sourcemaps to internal networks & opbeat.

@hmdhk
Copy link
Contributor

hmdhk commented Feb 2, 2016

Hi @ndreckshage,

Thanks for reaching out to us, this is an interesting use case. I will take note of this for future improvements.

Cheers,
Hamid

@ndreckshage
Copy link
Author

Thanks @jahtalab -- fwiw hidden is a bonus, ip is really a req for us to be able to use in prod. If that can be provided first

@roncohen
Copy link
Contributor

@ndreckshage Just wanted to let you know we're working towards a setup that will allow us to give out the ip addresses that we'll use to fetch sourcemaps

@ndreckshage
Copy link
Author

@roncohen great, thanks!

@roncohen
Copy link
Contributor

@ndreckshage hey! Would a solution where you upload the sourcemaps to our servers work as well?

@Zertz
Copy link

Zertz commented May 4, 2016

@roncohen As long as there is an API and can be automated :-)

@domdorn
Copy link

domdorn commented Jun 20, 2016

any updates on this? at least allow uploading the sourcemap for now... PLEASE!

@hmdhk
Copy link
Contributor

hmdhk commented Jun 20, 2016

Hi @domdorn ,
Thanks for your interest.
Unfortunately, there's no update. But we've taken a note of your request.

@domdorn
Copy link

domdorn commented Jun 20, 2016

too bad. this makes opbeat unusable for my client.

to clarify:
We cannot provide sourcemaps in a way, that they are publicly accessible.
thus we either need a way to identify the upbeat crawler like

  • whitelisting IPs
  • a special user agent and a shared secret in a header
  • some other way

or to allow to manually upload sourcemaps.

@hmdhk
Copy link
Contributor

hmdhk commented Jun 20, 2016

@domdorn ,

Thanks for your suggestions.
You are absolutely right, it is a very important feature and in fact we have looked into it and would like to provide it. However I cannot offer a timeline at the moment. I will consider this a big +1 for getting this feature out.

Cheers :)

@domdorn
Copy link

domdorn commented Jun 21, 2016

is there at least any indicator we can use to identify opbeat in the meantime?
IP-Range, User-Agent, IP-Reverse resolution (like google does)?

@b3rntsen
Copy link

+1 for this one @roncohen ;)

@AndrewGrachov
Copy link

upvote. Any update on this issue?

@hmdhk
Copy link
Contributor

hmdhk commented Jul 4, 2017

Thanks for reaching out @AndrewGrachov ,
Unfortunately, still no updates on this.
I will make sure that we reconsider providing this feature.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants