Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated tests #125

Open
jdelStrother opened this issue Nov 10, 2022 · 1 comment
Open

Automated tests #125

jdelStrother opened this issue Nov 10, 2022 · 1 comment

Comments

@jdelStrother
Copy link
Contributor

Any interest in adding more tests to this project?

I hacked together jdelStrother@995af44 that just checks that all the examples listed in the json match one of the user_agents regexes.
(half-a-dozen or so seem to have bad example UAs: https://github.com/jdelStrother/user-agents/actions/runs/3439700273/jobs/5737297616).

I didn't bother adding an actual test framework (eg jest) because I struggled to think of other tests I wanted to add, but I could add one if we thought it might expand in usage.

@johnspurlock
Copy link
Collaborator

There is a new version of this user-agents list over in opawg/user-agents-v2 that performs automated tests on every push/PR. In addition to basic JSON sanity checking, it also ensures that every example lands on its containing entry (and adds quite a few more examples!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@jdelStrother @johnspurlock and others