Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:kafka/commit-interval deprecated in or before 0.14.5.0? #62

Open
Quezion opened this issue Jul 30, 2019 · 0 comments
Open

:kafka/commit-interval deprecated in or before 0.14.5.0? #62

Quezion opened this issue Jul 30, 2019 · 0 comments

Comments

@Quezion
Copy link

Quezion commented Jul 30, 2019

Based on https://github.com/onyx-platform/onyx-kafka/blob/b092ad0e96bd52bb38e9b447834d78c072a0fb47/src/onyx/kafka/information_model.cljc , it should be valid to pass :kafka/commit-interval as a kafka-opt to the plugin.

Actually passing this results in a Schema validation error (I don't recall the exact, but something akin to "key not in namespace :onyx OR :kafka".

I expect that either:
A) The information model should be updated with "deprecated" for this field
B) This option is supposed to be valid but is missing from the Schema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant