-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding code snippets breaks dark theme #94
Comments
@Ppjet6, that's by design. |
If you want to adjust the chroma classes, you're out of luck with this theme. I should make that clear in the docs. |
Is it by design that blockquotes break the theme? |
Umh, is that the same issue or a separate issue? |
It's the same issue. It's the html that gets generated when I use blockquotes, as mentioned in the first post. |
It seems I misunderstood and misspoke. That said, I still don't get what Did a quick test and couldn't quite reproduce what you've described. Can you paste an example here? or send me a link |
https://codeberg.org/joinjabber/website-hugo/commit/3874c788bd7849d6b9f6ae93710265af9e254720 This is an example of a workaround for this issue (code blocks). I guess you can clone the website to try and reproduce. |
By all means. You didn't provide an actual example where the problem was happening. I see no blockquotes on the link, or how the |
Something on our website currently breaks block-quotes. I have a suspicion that it might be related to adding the |
Yeah it seems whatever generates |
Or maybe you have different markup settings . If that's the case, that would explain it. |
The markup settings should match 👇🏼 as is in the exampleSite.
|
Ok it looks like this is unrelated to We use the default configuration so this isn't it either. It's probably something in our custom sass that breaks it as @poVoq said. We need to figure out what. |
For me, this only happens when I use a code block, so 3x tilde like
These code blocks do indeed have the class It has nothing to do with custom SASS (I removed it all when testing). |
If I could see your repos, pretty confident I would point out what the problem is. I looked at your profiles and figured you're testing privately. |
Signed-off-by: weru <[email protected]>
@Ppjet6 has linked to it twice here, but it's https://codeberg.org/joinjabber/website-hugo/ There is no code block added to main branch right now because of the issue, but just add it yourself and you'll see it. |
Signed-off-by: weru <[email protected]>
@ltguillaume, thank you that clarification went a long way. It wasn't immediately obvious that was the fork. Plus the talk about blockquotes didn't help with the misunderstanding. This issue was about the code blocks/snippets breaking certain javascript functions. I have tested with your repo and discovered a javascript bug. Your repo should now work properly 👇🏼, after pulling the update. |
Thanks! This indeed fixes it. To explain why the Sorry again for the confusion and thanks for taking the time. |
Signed-off-by: weru <[email protected]>
I have checked all the prerequisites below and I'm yet experiencing a problem
Describe the bug
When I use blockquotes in markdown, the blockquote is properly displayed on the page but I am forced back in the light theme and it's not possible to change this. It also breaks some other parts of the page, such as parts of the left navbar.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: