Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: noClasses option issue #37

Closed
3 tasks done
foxisawesome opened this issue Feb 6, 2021 · 5 comments
Closed
3 tasks done

config: noClasses option issue #37

foxisawesome opened this issue Feb 6, 2021 · 5 comments

Comments

@foxisawesome
Copy link

I have checked all the prerequisites below and I'm yet experiencing a problem

  • Read the README.md
  • Have the extended version of Hugo installed
  • Used the exampleSite's config.toml as a reference

Describe the bug
While changing noClasses=true in config.toml file. the site cannot be change to light mode. It stuck at dark mode.

Desktop (please complete the following information):

  • chrome 88
@onweru
Copy link
Owner

onweru commented Feb 8, 2021

Umh, is this the line you're trying to edit?

@foxisawesome
Copy link
Author

Actually, I am trying to change line 39: noClasses = true in the file: exampleSite\config.toml. everything else untouched. Then I compiled the site. Went to chrome, found the the dark mode switch would NOT work for pages having python code highlighting blocks. Pages not having hightlight blocks can switch between dark mode and light mode.

@onweru
Copy link
Owner

onweru commented Feb 8, 2021

Oh, I see ... changing that will indeed break the theme. I will see if that's something I can accommodate going forward.

@hupfdule
Copy link

The same is true for code blocks with an invalid language specified.

For example the following code block breaks the dark mode (for that page):

```invalid
some test
```

If the term invalid is removed the dark mode works again.

@onweru
Copy link
Owner

onweru commented Dec 14, 2021

The same is true for code blocks with an invalid language specified.

For example the following code block breaks the dark mode (for that page):

```invalid
some test

If the term `invalid` is removed the dark mode works again.

@hupfdule, I couldn't reproduce the darkmode breaking when I copied this

@onweru onweru closed this as completed Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants