Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog feature in exampleSite is not working #24

Closed
danielfbm opened this issue Dec 1, 2020 · 4 comments
Closed

Blog feature in exampleSite is not working #24

danielfbm opened this issue Dec 1, 2020 · 4 comments

Comments

@danielfbm
Copy link

AFAIK this theme has some roots on clarity and some content is copied to the exampleSite for reference, but the blogging feature as described does not work

Looking through the partials of this theme I noticed that all the archive/blog post lists related features were removed. Is there any chance to add it back? if not please remove the related misleading content from the documentation/exampleSite ?

I am open to contributing if necessary, and most probably will just copy the functionality back from clarity

Talking about clarity, is there any plan to add back its code features? I can open another issue to track this one, if needed.

@onweru
Copy link
Owner

onweru commented Dec 1, 2020

@danielfbm,

Compose theme is primarily a documentation theme. Blogging function is at best a secondary concern and has been currently ignored on purpose. The intent being to get primary documentation features right first e.g search, table of contents, syntax highlighting ...

The exampleSite is contains docs for two themes:

  1. This theme, compose
  2. Clarity theme

I intend to add docs for other themes. Why? Because, it hits >= two birds with one stone i.e 1) That content is better than dummy lorem ipsum 2) That content serves a good real-world demo for this theme 3) Publish more structured docs for each theme which are better than long blocky READMEs. Thanks for raising the concern I will find ways to make it less confusing/misleading.

The code features are on the clarity theme; not on this theme. There are plans to add an equivalent of the same here. At the moment, #15 takes priority. The code features will then follow.

To surmise, the code features and blogging function are currently extraneous to this theme.

I am open to contributing if necessary, and most probably will just copy the functionality back from clarity

Contributing, absolutely. Copying it from clarity as-is now? I was holding back until we make it more robust on clarity 😄.

@danielfbm
Copy link
Author

I see, thank you so much for clarifying. For my use case, I would love to have a mixture of both themes. I can also see this working as a one-stop solution for documentation and blogging within one codebase.

@onweru
Copy link
Owner

onweru commented Dec 2, 2020

Eventually yes. I will keep this issue open

@onweru onweru reopened this Dec 2, 2020
@onweru onweru closed this as completed Dec 6, 2020
@HarborZeng
Copy link

looking forword to this feature.

@onweru onweru reopened this Mar 14, 2022
onweru added a commit that referenced this issue Jun 13, 2022
Signed-off-by: weru <[email protected]>
onweru added a commit that referenced this issue Jun 13, 2022
onweru added a commit that referenced this issue Jun 13, 2022
onweru added a commit that referenced this issue Jun 13, 2022
@onweru onweru closed this as completed Jun 13, 2022
hupfdule pushed a commit to poiu-de/compose that referenced this issue May 27, 2023
hupfdule pushed a commit to poiu-de/compose that referenced this issue May 27, 2023
hupfdule pushed a commit to poiu-de/compose that referenced this issue May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants