Resolve #112 #114
Merged
Resolve #112 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: - lite-yt-embed.css - lite-yt-embed.css. Modified: - exampleSite/content/shortcodes.md - layouts/partials/head.html
Modified: - exampleSite/config.toml I needed to use my repo instead of the master repo to get the files. This change is *NOT* needed for production.
Modified: - exampleSite/content/shortcodes.md - layouts/shortcodes/liteyoutube.html - exampleSite/go.mod -- do not merge - exampleSite/go.sum -- do not merge - exampleSite/resources/_gen/assets/sass/sass/main.sass_ae9eb86df8175869edaecf50caadd93b.content -- not needed???
Modified: - layouts/shortcodes/liteyoutube.html
forgot closing paren
Modified: - layouts/shortcodes/liteyoutube.html I made another syntax error. I decided to add another variable to avoid doing too much in a single command.
Modified: - exampleSite/content/shortcodes.md I had an extra line. I removed it.
Modified: - exampleSite/content/shortcodes.md - layouts/shortcodes/liteyoutube.html opted to use the "with" clause after learning about it. Also tried to go back to using no parameters.
So far, nothing I try works on handling both named and positional params in the shortcode. Trying again.
As it turns out, the bkImg had a scoping problem. I ended up with a fair amount of duplicated code because of it. Removed the debug printf statements and completed the shortcodes.md doc.
changed the config.toml and go.mod back to the original.
|
Sorry, @onweru. I do not know how to fix this failed check. The code works on my machine. All my check-ins are "verified." |
No problem, I'll review this asap i.e from Monday. Weekends can are kinda swarmed (crazy) on my end 😃 |
rwstorer
commented
Jun 12, 2023
rwstorer
commented
Jun 12, 2023
rwstorer
commented
Jun 12, 2023
rwstorer
commented
Jun 12, 2023
rwstorer
commented
Jun 12, 2023
change it back to onweru after the import
|
@onweru, I figured out that I needed to point the "exampleSite" to my repo during the test import for it to find the new shortcode. Naturally, you'll want to update that after the merge (or reject that change). Anyway, the PR passes all checks now. |
onweru
added a commit
that referenced
this pull request
Jul 9, 2023
Signed-off-by: weru <[email protected]>
onweru
added a commit
that referenced
this pull request
Jul 9, 2023
onweru
added a commit
that referenced
this pull request
Jul 9, 2023
Signed-off-by: weru <[email protected]>
onweru
pushed a commit
that referenced
this pull request
Jul 9, 2023
Signed-off-by: weru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR...
Adds liteyoutube by paulirish found here
Changes / fixes
Screenshots (if applicable)
(prefer animated gif)
Checklist
Ensure you have checked off the following before submitting your PR.