Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Protocol Support]: Add support for fetching non-https protocols #263

Closed
fallaciousreasoning opened this issue Jul 30, 2024 · 2 comments
Closed

Comments

@fallaciousreasoning
Copy link

Hey, thanks for the great plugin, it works really well. I've forked the repo and hacked in support for custom protocols so I can load tiles from IndexedDB. Would you be interested in a PR for the feature (if I clean it up)?

I know that this repo is probably going to be deprecated once maplibre/maplibre-style-spec#583 is resolved (and it'll give us native protocol support) but thought I'd check.

@msbarry
Copy link
Contributor

msbarry commented Jul 30, 2024

Thanks for reaching out! I'd rather not update/maintain any extra functionality in this plugin between now and when I get it incorporated as a first-class feature in maplibre. That IndexedDB functionality seems handy though as a way to load tiles when offline, is it open source? If not that might be an interesting project to make available for projects to use with other maplibre sources?

@fallaciousreasoning
Copy link
Author

Yeah, figured that might be the case 😄 It is yeah, but just as part of my side project https://alpha.topos.nz
https://github.com/fallaciousreasoning/topo/blob/alpha-react/src/caches/cachingProtocol.ts

I could probably move it into its own thing pretty easily. Okay, going to close this as wontfix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants