Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition from setup.py to pyproject.toml #87

Closed
hackdna opened this issue Feb 17, 2022 · 3 comments
Closed

Transition from setup.py to pyproject.toml #87

hackdna opened this issue Feb 17, 2022 · 3 comments
Assignees
Labels
technical debt Cruft and maintenance issues

Comments

@hackdna
Copy link
Member

hackdna commented Feb 17, 2022

"To avoid executing arbitrary scripts and boilerplate code, we are transitioning into a full-fledged setup.cfg to declare your package information instead of running setup()"
https://setuptools.pypa.io/en/latest/userguide/quickstart.html#transitioning-from-setup-py-to-setup-cfg

Test branch: https://github.com/onnela-lab/forest/tree/packaging-update

Required for #244

@hackdna hackdna added the enhancement New feature or request label Feb 17, 2022
@hackdna hackdna added technical debt Cruft and maintenance issues and removed enhancement New feature or request labels Oct 30, 2023
@hackdna hackdna changed the title Transition from setup.py to setup.cfg Transition from setup.py to setup.cfg or pyproject.toml Oct 22, 2024
@hackdna
Copy link
Member Author

hackdna commented Oct 25, 2024

Warning when running pip:

DEPRECATION: Legacy editable install of forest==0.1.1 (setup.py develop) is deprecated. pip 25.0 will enforce this behaviour change. A possible replacement is to add a pyproject.toml or enable --use-pep517, and use setuptools >= 64. If the resulting installation is not behaving as expected, try using --config-settings editable_mode=compat. Please consult the setuptools documentation for more information. Discussion can be found at pypa/pip#11457

@hackdna hackdna self-assigned this Oct 29, 2024
@hackdna hackdna changed the title Transition from setup.py to setup.cfg or pyproject.toml Transition from setup.py to pyproject.toml Nov 20, 2024
@hackdna
Copy link
Member Author

hackdna commented Nov 21, 2024

Addressed in ae6f171

@hackdna hackdna closed this as completed Nov 21, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Package and publish Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt Cruft and maintenance issues
Projects
Development

No branches or pull requests

1 participant