New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulnerabilities #2

Open

Merdi-kim opened this issue May 4, 2022 · 0 comments

Merdi-kim commented May 4, 2022

In the contract, I noticed these vulnerabilities:

On line 91 the condition should be oldPrice != _price so that when this evaluates to false, the error is fired
in the _validate() function we could enforce that price should be equal to msg.value so that we can avoid sending back tokens to the user if their msg.value was greater than the NFT price.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment