-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a set of displayType
's for Trait
struct
#130
Comments
I'm not really sure what you're suggesting here. Can you please elaborate? |
Ye sure! So in the comment above "displayType is used to show some context about what this name and value represent for instance, you could set value to a unix timestamp, and specify displayType as "Date" to tell platforms to consume this trait as a date and not a number" Since currently there is not list of |
That is a good suggestion! So these would just be listed in the comments above displayType and in the documentation, or would it be something that is actually defined in the contract? And what are your suggestions for which ones we should use? |
I think we should
.find have already started that above in our github repo but I am not sure if that is where it should be/live. Could we maybe setup a workshop to work on this with interested parties? |
@bjartek If you'd like to organize and lead a workshop about it, please feel free to plan it, and we can help organize, and promote it in the Flow community. :) |
I will see what I can cook together. I kind of like to have done some more internal thoughts about it first to present something that we at .find think is presentable before said meeting. Nothing that is set in stone I just like to have something coherent to send to participants in advance and present as a conversation-starter. |
Instructions
Restricting the
displayType
's for theTrait
struct would help with standardisation as it would inform off-chain consumers about what to expect and leave it up to them for how they consume the value contained in the Trait. I feel as though it is currently too vague to be truly useful, and a set of types should be provided that the dev can choose from.There are many different names for the same/similar types across programming languages so we should probably settle on some sort of standard. ISO/IEC 11404 might be a place to start:
https://en.wikipedia.org/wiki/ISO/IEC_11404#:~:text=ISO%2FIEC%2011404%2C%20General%20Purpose,such%20as%20Fortran%20or%20C).
https://www.iso.org/standard/39479.html
The text was updated successfully, but these errors were encountered: