Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Make WebSocket responses from data providers consistent with Access REST API responses #6802

Draft
wants to merge 72 commits into
base: master
Choose a base branch
from

Conversation

UlyanaAndrukhiv
Copy link
Contributor

@UlyanaAndrukhiv UlyanaAndrukhiv commented Dec 12, 2024

Closes: #6775

Note: this PR should be merged after #6766

Context

This pull request updates the WebSocket data providers to utilize the same models and response converters used by the Access REST API. By aligning the data processing logic, responses from WebSocket and REST API endpoints will now have consistent structure and content. Updated and added new unit tests to validate shared model usage.

AndriiDiachuk and others added 30 commits November 22, 2024 16:15
…:The-K-R-O-K/flow-go into AndriiDiachuk/6588-events-data-provider
…:The-K-R-O-K/flow-go into AndriiDiachuk/6588-events-data-provider
…:The-K-R-O-K/flow-go into AndriiDiachuk/6588-events-data-provider
…:The-K-R-O-K/flow-go into AndriiDiachuk/6588-events-data-provider
…The-K-R-O-K/flow-go into AndriiDiachuk/6587-accounts-data-provider
…The-K-R-O-K/flow-go into AndriiDiachuk/6587-accounts-data-provider
…:The-K-R-O-K/flow-go into AndriiDiachuk/6588-events-data-provider
…:The-K-R-O-K/flow-go into AndriiDiachuk/6588-events-data-provider
AndriiDiachuk and others added 22 commits December 9, 2024 13:29
…The-K-R-O-K/flow-go into UlyanaAndrukhiv/6775-websocket-responses
…m:The-K-R-O-K/flow-go into AndriiDiachuk/6588-events-data-provider
…The-K-R-O-K/flow-go into UlyanaAndrukhiv/6775-websocket-responses
…The-K-R-O-K/flow-go into UlyanaAndrukhiv/6775-websocket-responses
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 60.18692% with 213 lines in your changes missing coverage. Please review.

Project coverage is 41.04%. Comparing base (0310dfd) to head (3f2906f).

Files with missing lines Patch % Lines
...e/access/rest/common/models/mock/link_generator.go 14.37% 129 Missing and 2 partials ⚠️
.../rest/websockets/data_providers/events_provider.go 73.72% 22 Missing and 9 partials ⚠️
...ockets/data_providers/account_statuses_provider.go 76.78% 18 Missing and 8 partials ⚠️
.../rest/websockets/data_providers/blocks_provider.go 59.45% 10 Missing and 5 partials ⚠️
engine/access/rest/router/router.go 0.00% 5 Missing ⚠️
engine/access/rest/http/routes/blocks.go 70.00% 3 Missing ⚠️
...e/access/rest/websockets/data_providers/factory.go 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6802      +/-   ##
==========================================
+ Coverage   40.98%   41.04%   +0.05%     
==========================================
  Files        2079     2087       +8     
  Lines      183922   184387     +465     
==========================================
+ Hits        75382    75681     +299     
- Misses     102240   102364     +124     
- Partials     6300     6342      +42     
Flag Coverage Δ
unittests 41.04% <60.18%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Make WebSocket responses from data providers consistent with Access REST API responses.
4 participants