Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Add implementation for events data providers and account statuses data providers #6766

Open
wants to merge 59 commits into
base: master
Choose a base branch
from

Conversation

AndriiDiachuk
Copy link
Contributor

@AndriiDiachuk AndriiDiachuk commented Nov 27, 2024

Closes: #6588, #6587

In this PR EventsDataProvider and "AccountStatusesDataProvider" were implemented.

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 78.06452% with 68 lines in your changes missing coverage. Please review.

Project coverage is 41.03%. Comparing base (541d744) to head (2f0142d).

Files with missing lines Patch % Lines
.../rest/websockets/data_providers/events_provider.go 73.94% 22 Missing and 9 partials ⚠️
...ockets/data_providers/account_statuses_provider.go 76.78% 18 Missing and 8 partials ⚠️
.../rest/websockets/data_providers/blocks_provider.go 52.63% 6 Missing and 3 partials ⚠️
...e/access/rest/websockets/data_providers/factory.go 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6766      +/-   ##
==========================================
+ Coverage   40.95%   41.03%   +0.08%     
==========================================
  Files        2093     2096       +3     
  Lines      184432   184727     +295     
==========================================
+ Hits        75528    75809     +281     
+ Misses     102582   102562      -20     
- Partials     6322     6356      +34     
Flag Coverage Δ
unittests 41.03% <78.06%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndriiDiachuk AndriiDiachuk changed the title [Access] Add implementation for events data providers [Access] Add implementation for events data providers and account statuses data providers Dec 10, 2024
import "github.com/onflow/flow-go/model/flow"

// AccountStatusesResponse is the response message for 'events' topic.
type AccountStatusesResponse struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both AccountStatusesResponse and EventResponse models should be aligned with the implementation of the issue #6775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Add implementation for events data providers
5 participants